Remove pre-C++11 compatibility for noexcept.#2656
Merged
danpovey merged 1 commit intokaldi-asr:masterfrom Aug 30, 2018
Merged
Conversation
Contributor
|
I'd just remove it altogether, I don't think anyone would be using it and anyway it would just be a compilation error to fix. |
Contributor
Author
|
You're right. I updated this PR. This change is good to go. |
dpriver
pushed a commit
to dpriver/kaldi
that referenced
this pull request
Sep 13, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm happy to remove the KALDI_NOEXCEPT macro altogether, since no one sane should have depended on this macro in their code that uses Kaldi as an external library. I'm just being paranoid about backwards compatibility here.